[14.0][IMP]project_timeline: improved timeline handling for project tasks #1335
Conversation
|
Review the tests |
juanjosesegui-tecnativa
force-pushed
the
14.0-imp-project_timeline-handling
branch
from
9485aa4
to
43fbe38
Compare
|
This is funny but I just picked up this module and I have a functional question (sorry maybe unrelated to this PR): what is the reason to have the start/end fields in a tab accessible only through developer mode? Or is there something I'm missing in the whole picture? |
|
Because setting them manually without the timeline view is not the usual way. Anyway, please enable technical features for all your users through |
Sorry, what would be the "usual way"? I don't understand the reason for adding fields to a tab hidden by default, unless is there another way to set start/end time for a task I'm not aware of |
|
As said, the timeline view, not the form view. |
Thanks, I understand now! Better documentation could have saved both of us some time :) Would it be possible to use this PR to enhance USAGE in the following way:
|
juanjosesegui-tecnativa
force-pushed
the
14.0-imp-project_timeline-handling
branch
from
43fbe38
to
13e5007
Compare
Anyway this statement is not correct since when you create a new task, both "start date" and "end date" are not set so task does not appear in timeline view and there's no way to set start/end without dev mode access It's ok to keep it under dev mode (while I don't agree that it should be assumed everyone uses base_technical_features by default), I've updated the description accordingly. |
|
Furthermore (and then I'll stop as I don't want to hijack this PR) there's no constraint in setting end date before start date, resulting in glitchy behaviors in the view:
|
juanjosesegui-tecnativa
force-pushed
the
14.0-imp-project_timeline-handling
branch
from
13e5007
to
59d1444
Compare
|
@juanjosesegui-tecnativa please attend my comments. |
juanjosesegui-tecnativa
force-pushed
the
14.0-imp-project_timeline-handling
branch
3 times, most recently
from
38f5973
to
1ca2713
Compare
Hi @pedrobaeza , if something is missing, I'm not sure what it could be. Could you tell me what else is needed for it to be correct? |
pedrobaeza
force-pushed
the
14.0-imp-project_timeline-handling
branch
2 times, most recently
from
d7ce46f
to
66c9f75
Compare
pedrobaeza
force-pushed
the
14.0-imp-project_timeline-handling
branch
2 times, most recently
from
31524d3
to
594bcb4
Compare
The fields `date_assign` and `date_end` can't be used, as they are automatically rewritten on certain flow events (user assignation and stage changed to finished one), so we need dedicated fields for the planning. A previous change switches `date_assign` to `date_start`, but it didn't change demo data, and better to use a consistent naming, prefixing both fields with `planned_`. This includes the migration scripts for preserving previous data, and automations to fill planned data from the previous fields. It also pre-fills planning information from assignation date/close date as a best effort pre-planning for existing tasks. TT50618 Co-Authored-By: Pedro M. Baeza <[email protected]>
pedrobaeza
force-pushed
the
14.0-imp-project_timeline-handling
branch
from
594bcb4
to
42bd28c
Compare
|
/ocabot merge nobump @juanjosesegui-tecnativa forward-port it to upper versions |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 0fc41f1. Thanks a lot for contributing to OCA. ❤️ |
| The Task timeline uses the "Planned Start Date" and "Planned End Date" fields, in the | ||
| "Extra Info" tab (only visible in debug mode). | ||
|
|
||
| When a user is assigned, and there's no planned start date, current datetime is filled |
There was a problem hiding this comment.
TBH this is working only when new task is created from kanban, but not from form: video
There was a problem hiding this comment.
That seems a glitch of v14 + the widget. If you do it in 2 steps (create it, and the assign it), it should work. It's out of the scope of the module anyway. Update to newer versions of Odoo for ORM improvements.
There was a problem hiding this comment.
Sure, it was just a heads up in case it happens in later versions
| date_start="planned_date_start" | ||
| date_stop="planned_date_end" |
There was a problem hiding this comment.
@victoralmau @pedrobaeza these changes are causing an error in the model report.project.task.user because the fields do not exist there. Please review. I reverted it in the migration to 17. I believe the fields should be added to the model first before including them in the view.
9946227#diff-f2f81dcbaa2dc0db56e12f2ca784d921c1acbd33e73500563c4c07a455808fc2R65
There was a problem hiding this comment.
Please fix it here and don't revert in 17
@Tecnativa TT50618